[vlc-devel] [PATCH v2 14/14] picture: always copy context when cloning

[Rémi Denis-Courmont]

Le perjantaina 14. elokuuta 2020, 15.01.49 EEST Steve Lhomme a écrit :
> From: Alexandre Janniaux <ajanni at videolabs.io>
> 

p...

> icture_Clone was copying the original picture context into the new
> clone while picture_pool_Clone wasn't. As it is possible to create a
> pool from existing pictures, it's quite handy to be able to associate
> the graphical resources needed for each picture to their context so
> that it can be retrieved after a call to picture_pool_Wait/Get.
> 
> The rationale is that because resources like pixels are shared between
> the original picture and the clone, we should probably do the same with
> picture_context and have a unified way for picture producer to
> reference such resources.

Not sure this will work. Originally, picture context was specifically meant to 
work-around the pool and not do that.

What is the practical use case, and why can't it use picture_t.sys?

-- 
レミ・デニ-クールモン
http://www.remlab.net/