[vlc-devel] [PATCH v2 11/14] picture: pass the opaque pointer to the destroy callback rather than the picture

Steve Lhomme robux4 at ycbcr.xyz
Mon Aug 17 09:18:22 CEST 2020

On 2020-08-14 17:43, Rémi Denis-Courmont wrote:
> Le perjantaina 14. elokuuta 2020, 15.01.46 EEST Steve Lhomme a écrit :
>> The resource desctrutor shouldn't have to know much about the picture nor if
>> it's still allocated or not.
> Spelling.
>> This avoids some container_of in the picture_pool.
> Well yes, but there could be GC callbacks that need to read some fields in
> picture_t, no?

There's no such case anymore. The resources rarely depend on something 
in the pictures. For now only the number of planes was actually needed.

This is mostly to make picture_priv_t really private.

More information about the vlc-devel mailing list