[vlc-devel] [RFC PATCH 2/7] contrib: add libebur128

[Thomas Guillem]

On Mon, Aug 17, 2020, at 08:42, Steve Lhomme wrote:
> On 2020-08-14 15:18, Thomas Guillem wrote:
> > EBU R128 standard for loudness normalisation. It will be used for a future
> > ebur128 audio-filter that will measure loudness.
> > ---
> >   contrib/src/libebur128/SHA512SUMS |  1 +
> >   contrib/src/libebur128/rules.mak  | 25 +++++++++++++++++++++++++
> >   2 files changed, 26 insertions(+)
> >   create mode 100644 contrib/src/libebur128/SHA512SUMS
> >   create mode 100644 contrib/src/libebur128/rules.mak
> > 
> > diff --git a/contrib/src/libebur128/SHA512SUMS b/contrib/src/libebur128/SHA512SUMS
> > new file mode 100644
> > index 00000000000..37e9774d9c4
> > --- /dev/null
> > +++ b/contrib/src/libebur128/SHA512SUMS
> > @@ -0,0 +1 @@
> > +d9aec133aca9240f7e859aae30cfcab07ba7aa20378187d53dfeec4cd3840d49bb117fa0698591bac04d95f9d8b5cd0b1fbe41c364694f2fa8267dd690b2dc02  libebur128-1.2.4.tar.gz
> > diff --git a/contrib/src/libebur128/rules.mak b/contrib/src/libebur128/rules.mak
> > new file mode 100644
> > index 00000000000..ba91a50a0e2
> > --- /dev/null
> > +++ b/contrib/src/libebur128/rules.mak
> > @@ -0,0 +1,25 @@
> > +# EBU R128 standard for loudness normalisation
> > +
> > +LIBEBUR128_VERSION := 1.2.4
> > +LIBEBUR128_URL := https://github.com/jiixyj/libebur128/archive/v$(LIBEBUR128_VERSION).tar.gz
> > +
> > +PKGS += libebur128
> > +ifeq ($(call need_pkg,"libebur128"),)
> > +PKGS_FOUND += libebur128
> > +endif
> > +
> > +$(TARBALLS)/libebur128-$(LIBEBUR128_VERSION).tar.gz:
> > +	$(call download_pkg,$(LIBEBUR128_URL),libebur128)
> > +
> > +.sum-libebur128: libebur128-$(LIBEBUR128_VERSION).tar.gz
> > +
> > +libebur128: libebur128-$(LIBEBUR128_VERSION).tar.gz .sum-libebur128
> > +	$(UNPACK)
> > +	$(call pkg_static,"./ebur128/libebur128.pc.cmake")
> > +	$(MOVE)
> > +
> > +.libebur128: libebur128 toolchain.cmake
> > +	cd $< && $(HOSTVARS_PIC) $(CMAKE)
> > +	cd $< && $(MAKE) install
> > +	rm -f $(PREFIX)/lib/libebur128.so*
> 
> Why is that ? There is no way to disable the dynamic loading building in 
> cmake ? (We use the default variable in most cmake targets)

This project doesn't handle BUILD_SHARED_LIBS:BOOL.

If this patch set is approved and this projet used by VLC, we could propose a patch.

> 
> > +	touch $@
> > -- 
> > 2.28.0
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel