[vlc-devel] [PATCH v3 03/12] vout: opengl: do not setup the picture planes a second time

Steve Lhomme robux4 at ycbcr.xyz
Tue Aug 18 08:24:44 CEST 2020


The opengl interop doesn't need to reset the picture planes as they are not
altered anymore by fake resources.
---
 modules/video_output/opengl/interop_sw.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/modules/video_output/opengl/interop_sw.c b/modules/video_output/opengl/interop_sw.c
index 486b2b3f1dd..3d0bd94dd1f 100644
--- a/modules/video_output/opengl/interop_sw.c
+++ b/modules/video_output/opengl/interop_sw.c
@@ -80,13 +80,6 @@ pbo_picture_create(const struct vlc_gl_interop *interop)
     interop->vt->GenBuffers(pic->i_planes, picsys->buffers);
     picsys->DeleteBuffers = interop->vt->DeleteBuffers;
 
-    /* XXX: needed since picture_NewFromResource override pic planes */
-    if (picture_Setup(pic, &interop->fmt_out))
-    {
-        picture_Release(pic);
-        return NULL;
-    }
-
     assert(pic->i_planes > 0
         && (unsigned) pic->i_planes == interop->tex_count);
 
-- 
2.26.2



More information about the vlc-devel mailing list