[vlc-devel] [PATCH v2 1/3] video_output: don't use the private pool for the blend picture

Rémi Denis-Courmont remi at remlab.net
Thu Aug 20 10:14:35 CEST 2020


Hi,

Actually that would not work in the case that the display supports blending but the core is doing a snapshot. In the long term, I've been wanting to separate those two blending scenarii but for now, I guess the patch is acceptable.

Performance sucks for non-blending displays anyhow due to picture_Copy().

Le 19 août 2020 22:23:36 GMT+02:00, "Rémi Denis-Courmont" <remi at remlab.net> a écrit :
>Le lundi 17 août 2020, 17:32:59 EEST Steve Lhomme a écrit :
>> Create one on the fly each time. We don't need to preallocate some
>> pictures if we're never going to use them. Also we don't to know the
>target
>> format in advance.
>
>Allocating pictures repeatedly might be slow though. It might be safer
>to 
>allocate a small (really private) pool when the display cannot blend.
>
>
>-- 
>Rémi Denis-Courmont
>
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200820/bfe5e6de/attachment.html>


More information about the vlc-devel mailing list