[vlc-devel] [PATCH 2/2] lua: http: Expose renderers

Hugo Beauzée-Luyssen hugo at beauzee.fr
Fri Aug 21 14:40:04 CEST 2020

> If local _rd actually works for storing, okay.

It does return the same RD instance the 2nd time, yes

> Can we have an explanation, and preferably a comment in the code, why
> mdns is used and hardcoded here? What if the mdns module wasn't built?

Because mdns_renderer is the type that will find chromecast modules and that's the main use case IMO. We most likely will need to come up with a way of aggregating various renderer types though, but I believe that's out of the scope for this patch.
If that's good enough of an explanation I can add this in the code.
If no mdns module was built, then get_renderer_discovery will return nil, and an empty array will be returned or no renderer will be selected.

On Fri, Aug 21, 2020, at 1:43 PM, Pierre Ynard via vlc-devel wrote:
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> Attachments:
> * Email.eml

  Hugo Beauzée-Luyssen
  hugo at beauzee.fr

More information about the vlc-devel mailing list