[vlc-devel] [PATCH 2/2] lua: http: Expose renderers

[Hugo Beauzée-Luyssen]

On Fri, Aug 21, 2020, at 3:19 PM, Alexandre Janniaux wrote:
> Hi,
> 
> On Fri, Aug 21, 2020 at 02:40:04PM +0200, Hugo Beauzée-Luyssen wrote:
> > > If local _rd actually works for storing, okay.
> >
> > It does return the same RD instance the 2nd time, yes
> >
> > > Can we have an explanation, and preferably a comment in the code, why
> > > mdns is used and hardcoded here? What if the mdns module wasn't built?
> >
> > Because mdns_renderer is the type that will find chromecast modules and that's the main use case IMO.
> 
> It should probably also try avahi and bonjour before mdns then. :)
> 
> Regards,

Just to clarify a potential misunderstanding, "mdns_renderer" here stands for Multicast DNS renderer", not "microdns renderer". Loading a module of type mdns_renderer will load either avahi, microdns, or bonjour, depending on the platform and built modules.
As pointed out by Rémi we need to enforce a type of renderer (ie. upnp_renderer VS mdns_renderer) and can't just ask for whichever comes first.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr