[vlc-devel] [PATCH] stream_filter: fix null dereference by modules/demux/mpeg/ts.c

[Akinobu Mita]

2020年8月22日(土) 0:07 Francois Cartegnie <fcvlcdev at free.fr>:
>
> Le 21/08/2020 à 17:01, Akinobu Mita a écrit :
> > This revers commit daeddd9bc724da5aa3c364c5b382da963f92b5b8
> > ("stream_filter: remove tautology test").
> >
> > The close callback for MPEG Transport Stream demuxer module sets the
> > b25stream's input stream to NULL and deletes the b25stream by calling
> > vlc_stream_Delete() which ends up calling StreamDelete().
> > (See /* don't chain kill demuxer's source */ comment in
> > modules/demux/mpeg/ts.c)
> >
> > This change restores the test against NULL input stream in StreamDelete()
> > to avoid NULL dereference.
>
> Or fix stream_Delete() trying to deref module

Fine with me.