[vlc-devel] [PATCH] stream_filter: fix null dereference by modules/demux/mpeg/ts.c

Francois Cartegnie fcvlcdev at free.fr
Sun Aug 23 14:52:02 CEST 2020

Le 21/08/2020 à 20:54, Rémi Denis-Courmont a écrit :
> Le vendredi 21 août 2020, 18:01:17 EEST Akinobu Mita a écrit :
>> This revers commit daeddd9bc724da5aa3c364c5b382da963f92b5b8
>> ("stream_filter: remove tautology test").
> I don't follow. A stream filter should always have a constant and non-NULL ->s, 
> deleted by the owner of the stream filter by the patched code.
> This sounds like a bug in the TS plugin, not the code.

The root issue is that we can't "unplug" a consumer stream filter
without having stream_Delete() recursing on parents.

The upstream was set to NULL to prevent chain deletion when used on
demux's own stream. As long as the consumer is not threaded, that was a
good enough solution without introducing new API.

Maybe that can be solved locally by implementing a stream filter to be
placed in the middle and which can prevent recursing.

Francois Cartegnie
VideoLAN - VLC Developer

More information about the vlc-devel mailing list