[vlc-devel] [PATCH] video_output: remove write-only "mouse-clicked"

Steve Lhomme robux4 at ycbcr.xyz
Mon Aug 24 08:26:17 CEST 2020


---
 src/video_output/video_output.c | 11 +----------
 src/video_output/vout_intf.c    |  1 -
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
index a2c33fb610f..8989206ece1 100644
--- a/src/video_output/video_output.c
+++ b/src/video_output/video_output.c
@@ -1649,18 +1649,9 @@ static void ThreadProcessMouseState(vout_thread_sys_t *p_vout,
     if (vlc_mouse_HasMoved(&sys->mouse, m))
         var_SetCoords(vout, "mouse-moved", m->i_x, m->i_y);
 
-    if (vlc_mouse_HasButton(&sys->mouse, m)) {
+    if (vlc_mouse_HasButton(&sys->mouse, m))
         var_SetInteger(vout, "mouse-button-down", m->i_pressed);
 
-        if (vlc_mouse_HasPressed(&sys->mouse, m, MOUSE_BUTTON_LEFT)) {
-            /* FIXME? */
-            int x, y;
-
-            var_GetCoords(vout, "mouse-moved", &x, &y);
-            var_SetCoords(vout, "mouse-clicked", x, y);
-        }
-    }
-
     if (m->b_double_click)
         var_ToggleBool(vout, "fullscreen");
     sys->mouse = *m;
diff --git a/src/video_output/vout_intf.c b/src/video_output/vout_intf.c
index ce50616fc9f..4fb207ff469 100644
--- a/src/video_output/vout_intf.c
+++ b/src/video_output/vout_intf.c
@@ -276,7 +276,6 @@ void vout_CreateVars( vout_thread_t *p_vout )
     /* Mouse coordinates */
     var_Create( p_vout, "mouse-button-down", VLC_VAR_INTEGER );
     var_Create( p_vout, "mouse-moved", VLC_VAR_COORDS );
-    var_Create( p_vout, "mouse-clicked", VLC_VAR_COORDS );
 
     /* Device orientation */
     var_Create( p_vout, "viewpoint-moved", VLC_VAR_ADDRESS );
-- 
2.26.2



More information about the vlc-devel mailing list