[vlc-devel] [PATCH] [RFC]: rav1e/rust: handle rustup/cargo from contribs (to fixup)

Steve Lhomme robux4 at ycbcr.xyz
Mon Aug 24 10:17:18 CEST 2020


On 2020-08-24 10:12, Thomas Guillem wrote:
> 
> 
> On Sat, Aug 22, 2020, at 09:09, Rémi Denis-Courmont wrote:
>> Hi,
>>
>> Contribs/bin is fine for build tools. The name was just odd.
> 
> Steve raised a good point. Can vlc modules easily have access to 
> contribs/bin ?

It's doable, see how luac or moc are handled in configure.ac. That's not 
looking good. So if it can be in extras/tools/build/bin it's cleaner. If 
you need a .cargo folder anyway then it doesn't have much of an 
advantage to be placed in tools anymore.

>>
>> Le 21 août 2020 20:58:35 GMT+02:00, Thomas Guillem <thomas at gllm.fr> a 
>> écrit :
>>
>>
>>
>>     On Fri, Aug 21, 2020, at 20:52, Rémi Denis-Courmont wrote:
>>
>>         Le vendredi 21 août 2020, 15:16:46 EEST Thomas Guillem a écrit :
>>
>>             Instead of installing rustup from extra/tools and
>>             installing cargo with all
>>             common targets. Install only rustup and cargo with the
>>             correct target when
>>             needed by a contrib package.
>>
>>             The rustup/cargo installation is in contrib/bin/.cargo.
>>
>>         Is it really supposed to be called .cargo ? A hidden name for
>>         a well-known
>>         executable is rather weird.
>>
>>
>>     It's in $HOME/.cargo by default. We could put it in
>>     vlc/contrib/cargo also.
>>
>>     >
>>
>>         -- 
>>         Rémi Denis-Courmont
>>         ------------------------------------------------------------------------
>>         vlc-devel mailing list
>>         To unsubscribe or modify your subscription options:
>>         https://mailman.videolan.org/listinfo/vlc-devel
>>
>>     ------------------------------------------------------------------------
>>     vlc-devel mailing list
>>     To unsubscribe or modify your subscription options:
>>     https://mailman.videolan.org/listinfo/vlc-devel
>>
>>
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez 
>> excuser ma brièveté.
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list