[vlc-devel] [PATCH] stream_filter: fix null dereference by modules/demux/mpeg/ts.c

Francois Cartegnie fcvlcdev at free.fr
Mon Aug 24 19:02:04 CEST 2020

Le 24/08/2020 à 15:50, Rémi Denis-Courmont a écrit :
> Even if you know that the stream is actually stream filter, you don't know what 
> state it left the underlying stream in (e.g., set some PID filtering), so 
> there's nothing you can and should do with it.

There's no reason for not being able to "stream filter" a demux stream,
in the demux, without causing a double free.

> This code is breaking an abstraction on *both* sides really.

Can be moved in the preload/cache/record chain.

A dummy "cam" stream filter with its CAM loading controls will add
useless redirection calls on each read in 99.9999% of the uses.

Francois Cartegnie
VideoLAN - VLC Developer

More information about the vlc-devel mailing list