[vlc-devel] [PATCH 2/8] contrib: specify the .sum- prefix in the checksum function

[Thomas Guillem]

On Wed, Aug 26, 2020, at 08:26, Steve Lhomme wrote:
> On 2020-08-25 16:45, Thomas Guillem wrote:
> > This will be used for .cargo-vendor-*-sum
> 
> This naming will prevent "make fetch" from downloading the Rust code. Is 
> it intentional ?

No it is not, good catch.
Specially since make fetch can be used to check which package (or vendor now) are not uploaded into the VideoLAN FTP.

> 
> The rule is
>    fetch: $(PKGS:%=.sum-%)
> 
> > ---
> >   contrib/src/main.mak | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/contrib/src/main.mak b/contrib/src/main.mak
> > index 0266e2a1199..d0df860a954 100644
> > --- a/contrib/src/main.mak
> > +++ b/contrib/src/main.mak
> > @@ -363,10 +363,10 @@ check_githash = \
> >   checksum = \
> >   	$(foreach f,$(filter $(TARBALLS)/%,$^), \
> >   		grep -- " $(f:$(TARBALLS)/%=%)$$" \
> > -			"$(SRC)/$(patsubst .sum-%,%,$@)/$(2)SUMS" &&) \
> > +			"$(SRC)/$(patsubst $(3)-%,%,$@)/$(2)SUMS" &&) \
> >   	(cd $(TARBALLS) && $(1) /dev/stdin) < \
> > -		"$(SRC)/$(patsubst .sum-%,%,$@)/$(2)SUMS"
> > -CHECK_SHA512 = $(call checksum,$(SHA512SUM),SHA512)
> > +		"$(SRC)/$(patsubst $(3)-%,%,$@)/$(2)SUMS"
> > +CHECK_SHA512 = $(call checksum,$(SHA512SUM),SHA512,.sum)
> >   UNPACK = $(RM) -R $@ \
> >   	$(foreach f,$(filter %.tar.gz %.tgz,$^), && tar xvzfo $(f)) \
> >   	$(foreach f,$(filter %.tar.bz2,$^), && tar xvjfo $(f)) \
> > -- 
> > 2.28.0
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel