[vlc-devel] [PATCH v3 00/20] Move picture placement in the core

Steve Lhomme robux4 at ycbcr.xyz
Wed Aug 26 13:55:27 CEST 2020


Changes since v2:
- use a helper function to flip the placement vertically
- no more enum to ask to do the placement from top-left or bottom-left
- simplify the win32 code where the common code has less cruft

Changes since v1:
- integrated the patch to pass the alignment origin to vout_display_PlacePicture()
- the origin is passed as an enum
- the display config is no longer modifiable by the display modules
- OpenGL module compute their local (inverted) placement using the new simplified
  vout_display_PlacePicture API
- fix MMAL resolution reporting/placement


Steve Lhomme (20):
  vlc_vout_display: add a helper function to flip the vertical placement
    value
  opengl: flip the vertical placement when using the placed picture area
  display: use vd->cfg directly in
    VOUT_DISPLAY_CHANGE_xxx/RESET_PICTURES
  display: don't pass an unused const vout_display_cfg_t* to
    VOUT_DISPLAY controls
  opengl: compute the picture placement when we are using it
  vout: win32: remove unused parameters
  vout: fix warning on unused va_list
  display: keep the placed picture on open and after changing display
    settings
  xcb/x11: use the picture placement from the core on open
  vdpau/display: use the picture placement from the core on open
  vdpau/display: use the picture placement from the core
  wayland/shm: use the picture placement from the core
  kva: use the placed picture dimensions from the core
  xcb: use the placed picture dimensions from the core
  vout: vulkan: use the placed picture dimensions from the core
  vout: win32: use the placed picture dimensions from the core
  opengl: use the placed picture flipped from the core dimensions
  display: log when the source or picture placement changes
  vout: win32: simplify setting the placement as changed
  mmal: vout: simplify the code to update the display resolution

 include/vlc_vout_display.h              | 55 ++++++++++------
 modules/hw/mmal/vout.c                  | 84 +++++++------------------
 modules/hw/vdpau/display.c              | 39 +++++-------
 modules/video_output/android/display.c  |  7 +--
 modules/video_output/caopengllayer.m    | 11 +---
 modules/video_output/ios.m              |  7 +--
 modules/video_output/kva.c              | 22 +++----
 modules/video_output/macosx.m           | 27 +++-----
 modules/video_output/opengl/display.c   | 32 ++--------
 modules/video_output/vulkan/display.c   | 12 ++--
 modules/video_output/wayland/shm.c      | 26 ++++----
 modules/video_output/win32/common.c     | 53 ++++------------
 modules/video_output/win32/common.h     | 13 ++--
 modules/video_output/win32/direct3d11.c | 48 +++++++-------
 modules/video_output/win32/direct3d9.c  | 34 +++++-----
 modules/video_output/win32/glwin32.c    | 14 ++---
 modules/video_output/win32/wingdi.c     | 22 ++++---
 modules/video_output/xcb/render.c       | 25 ++++----
 modules/video_output/xcb/x11.c          | 29 ++++-----
 src/video_output/display.c              | 79 +++++++++++++++--------
 src/video_output/video_output.c         |  9 ++-
 21 files changed, 278 insertions(+), 370 deletions(-)

-- 
2.26.2



More information about the vlc-devel mailing list