[vlc-devel] [PATCH v3 18/20] display: log when the source or picture placement changes

[Rémi Denis-Courmont]

Le keskiviikkona 26. elokuuta 2020, 14.55.45 EEST Steve Lhomme a écrit :
> ---
>  modules/video_output/win32/common.c | 9 ---------
>  src/video_output/display.c          | 9 +++++++++
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/modules/video_output/win32/common.c
> b/modules/video_output/win32/common.c index 64f635cb578..b76a2f44e1b 100644
> --- a/modules/video_output/win32/common.c
> +++ b/modules/video_output/win32/common.c
> @@ -98,15 +98,6 @@ void CommonPlacePicture(vout_display_t *vd,
> display_win32_area_t *area) /* Update the window position and size */
>      {
>          area->place_changed |= true;
> -
> -#ifndef NDEBUG
> -        msg_Dbg(vd, "UpdateRects source offset: %i,%i visible: %ix%i
> decoded: %ix%i", -            vd->source.i_x_offset, vd->source.i_y_offset,
> -            vd->source.i_visible_width, vd->source.i_visible_height,
> -            vd->source.i_width, vd->source.i_height);
> -        msg_Dbg(vd, "UpdateRects image_dst coords: %i,%i %ix%i",
> -            vd->place->x, vd->place->y, vd->place->width,
> vd->place->height); -#endif
>      }
>  }
> 
> diff --git a/src/video_output/display.c b/src/video_output/display.c
> index 58ff640bdc9..ae92940adda 100644
> --- a/src/video_output/display.c
> +++ b/src/video_output/display.c
> @@ -471,6 +471,15 @@ static void UpdatePicturePlace(vout_display_priv_t
> *osys) {
>      vout_display_t *vd = &osys->display;
>      vout_display_PlacePicture(&osys->place, &vd->source, vd->cfg);
> +
> +#ifndef NDEBUG
> +    msg_Dbg(vd, "UpdateRects source offset: %i,%i visible: %ix%i decoded:
> %ix%i", +        vd->source.i_x_offset, vd->source.i_y_offset,
> +        vd->source.i_visible_width, vd->source.i_visible_height,
> +        vd->source.i_width, vd->source.i_height);
> +    msg_Dbg(vd, "UpdateRects image_dst coords: %i,%i %ix%i",
> +        vd->place->x, vd->place->y, vd->place->width, vd->place->height);
> +#endif
>  }

The format strings does not look very proper.

> 
>  static void vout_display_Reset(vout_display_t *vd)


-- 
レミ・デニ-クールモン
http://www.remlab.net/