[vlc-devel] [PATCH 0/3] Fix --crop/--zoom/--aspect-ratio command line usage

[Thomas Guillem]

On Thu, Aug 27, 2020, at 17:44, Rémi Denis-Courmont wrote:
> Le torstaina 27. elokuuta 2020, 18.01.45 EEST Thomas Guillem a écrit :
> > On Thu, Aug 27, 2020, at 16:51, Rémi Denis-Courmont wrote:
> > > Le torstaina 27. elokuuta 2020, 13.06.32 EEST Steve Lhomme a écrit :
> > > > Not sure why these were commited.
> > > 
> > > We had a vote and decided to do that.
> > 
> > I don't really remember (the original commit log lacks some explanation).
> > I'm not against that decision but I don't think it was decided to break CLI
> > and LibVLC.
> 
> > > > But it breaks setting these values from the command-line
> > > 
> > > CLI works for me.
> > 
> > I'm curious to know what CLI command you are using.
> 
> vlc --zoom 1
> vlc --zoom 2
> 
> Pretty obvious that the video is zoomed.

vlc --aspect "16:9"

Pretty obvious that the video is not 16:9.

No, I'm kidding, it's not obvious at all:

It works for zoom because the "zoom" var is fetch from VoutGetDisplayCfg() and it is not the case for "crop" and "aspect". 

2 solutions:
 - Apply Steve's revert for "crop" and "aspect"
 - Initlialize "crop" and "aspect" from VoutGetDisplayCfg() by fetching those variables.

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel