[vlc-devel] [PATCH] configure.ac: use absolute path for protoc

[Alexandre Janniaux]

Hi,

Any feedback regarding this? Should it be done differently?

Regards,
--
Alexandre Janniaux
Videolabs

On Mon, Jul 13, 2020 at 05:27:37PM +0200, Alexandre Janniaux wrote:
> Hi,
>
> It works this way since Sat Oct 11 13:35:10 2014 +0000
>
> # configure.ac
>
>     dnl Add extras/tools to the PATH
>     TOOLS_DIR="${srcdir}/extras/tools/build/bin"
>     AS_IF([test -d "${TOOLS_DIR}"], [
>         TOOLS_DIR=`cd "${TOOLS_DIR}" && pwd`
>         export PATH="${TOOLS_DIR}:$PATH"
>     ])
>
> But I don't think it's an unwanted effect and it's probably
> what everybody doing cross compilation want. or else we need
> to put extras/tools in an different search path than PATH in
> configure.
>
> Regards,
> --
> Alexandre Janniaux
> Videolabs
>
> On Mon, Jul 13, 2020 at 06:17:10PM +0300, Rémi Denis-Courmont wrote:
> > Le maanantaina 13. heinäkuuta 2020, 18.08.54 EEST Alexandre Janniaux a écrit :
> > > Hi,
> > >
> > > Actually the workaround has been in the calling code (in
> > > the extras/package build script for apple) which
> > > systematically added the extras/tools in the PATH.
> > >
> > > Without this workaround, the configure script returns:
> > >
> > >     configure:55687: checking for protoc
> > >     configure:55703: found
> > > /home/alexandre/workspace/videolabs/vlc-meson/extras/tools/build/bin/protoc
> > > configure:55714: result: protoc
> > >
> > > And right after, make returns:
> > >
> > >     /bin/bash: protoc: command not found
> > >     Makefile:31476: recipe for target
> > > 'stream_out/chromecast/cast_channel.pb.h' failed
> >
> > Then the PATH is messed up somewhere.
> >
> > That makes no difference relative to this patch: build tools are detected with
> > AC_CHECK_* not AC_PATH_*.
> >
> > --
> > Rémi Denis-Courmont
> > http://www.remlab.net/
> >
> >
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel