[vlc-devel] [PATCH] omxil: remove dead code

[Steve Lhomme]

On 2020-12-03 10:09, Steve Lhomme wrote:
> It seems correct but the api.start callback doesn't seem to return clean 
> values. The start callbacks from mediacodec_jni.c and mediacodec_ndk.c
> return 0 or MC_API_ERROR. They should return VLC_SUCCESS/VLC_Exxx values.

In fact even StartMediaCodec() return 0 or MC_API_ERROR. So testing the 
result against VLC_xxx values is just bogus.

> On 2020-12-02 20:46, remi at remlab.net wrote:
>> From: Rémi Denis-Courmont <remi at remlab.net>
> 
> Not necessary.
> 
>> That error code cannot be returned here.
>> ---
>>   modules/codec/omxil/mediacodec.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/modules/codec/omxil/mediacodec.c 
>> b/modules/codec/omxil/mediacodec.c
>> index 041faa9a46..e5dae9343f 100644
>> --- a/modules/codec/omxil/mediacodec.c
>> +++ b/modules/codec/omxil/mediacodec.c
>> @@ -1647,8 +1647,6 @@ static int DecodeBlock(decoder_t *p_dec, block_t 
>> *p_in_block)
>>               case VLC_SUCCESS:
>>                   msg_Warn(p_dec, "Restarted from DecodeBlock");
>>                   break;
>> -            case VLC_ENOOBJ:
>> -                break;
>>               default:
>>                   msg_Err(p_dec, "StartMediaCodec failed");
>>                   AbortDecoderLocked(p_dec);
>> -- 
>> 2.29.2
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel