[vlc-devel] [PATCH] configure: do not use wordexp on iOS/tvOS

Alexandre Janniaux ajanni at videolabs.io
Thu Dec 3 11:39:20 CET 2020


Hi,

LGTM. It's much more elegant than the method I suggested
and could be extended with a supplementary file doing
feature test specially for iOS, thus overriding the usual
feature test in configure.ac for versionned SDK, for methods
only available on some SDK targets.

Regards,
--
Alexandre Janniaux
Videolabs

On Wed, Dec 02, 2020 at 03:13:14PM +0100, Marvin Scholz wrote:
> ---
>  configure.ac | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index e67bb7e2966..2b4e5741ef3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -213,7 +213,8 @@ case "${host_os}" in
>               #if TARGET_OS_IPHONE
>               yes
>               #endif],
> -             [HAVE_IOS="1"],
> +             [HAVE_IOS="1"
> +             ac_cv_func_wordexp=no],
>               [HAVE_OSX="1"])
>
>      AC_EGREP_CPP(yes,
> --
> 2.24.3 (Apple Git-128)
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list