[vlc-devel] [PATCH] omxil: remove dead code

Rémi Denis-Courmont remi at remlab.net
Thu Dec 3 17:42:58 CET 2020


Le torstaina 3. joulukuuta 2020, 18.38.15 EET Romain Vimont a écrit :
> On Thu, Dec 03, 2020 at 06:28:00PM +0200, Rémi Denis-Courmont wrote:
> > Le torstaina 3. joulukuuta 2020, 11.09.25 EET Steve Lhomme a écrit :
> > > It seems correct but the api.start callback doesn't seem to return clean
> > > values. The start callbacks from mediacodec_jni.c and mediacodec_ndk.c
> > > return 0 or MC_API_ERROR. They should return VLC_SUCCESS/VLC_Exxx
> > > values.
> > > 
> > > On 2020-12-02 20:46, remi at remlab.net wrote:
> > > > From: Rémi Denis-Courmont <remi at remlab.net>
> > > 
> > > Not necessary.
> > 
> > Not necessary what?
> > 
> > I'm not taking feedback on how git-send-email formats patches.
> 
> git send-email adds this line if your e-mail From header is different
> from the patch author.

> Here, the patch author is 'Rémi Denis-Courmont <remi at remlab.net>' while
> the e-mail From header is 'remi at remlab.net'.

Thanks captain obvious, but I am still not taking feedback on how git-send-
email formats patches.

-- 
レミ・デニ-クールモン
http://www.remlab.net/





More information about the vlc-devel mailing list