[vlc-devel] [PATCH] qt: medialib: fix signal name

[Pierre Lamot]

I'm OK for the patch.

On 2020-12-03 18:08, Romain Vimont wrote:
> I did not wanted to submit this patch now, it was just a test related 
> to
> this discussion:
> https://mailman.videolan.org/pipermail/vlc-devel/2020-December/140751.html
> 
> I wanted to send it to my own address, but apparently I failed :)
> 
> But now that it is submitted, I guess it's valid and can be
> reviewed/merged.
> 
> Regards
> 
> On Thu, Dec 03, 2020 at 05:33:40PM +0100, rom at rom1v.com wrote:
>> From: Romain Vimont <rom1v at videolabs.io>
>> 
>> By convention, xxxChanged() is for signals, while onXxxChanged() is 
>> for
>> slots.
>> ---
>>  modules/gui/qt/medialibrary/mlvideo.cpp | 2 +-
>>  modules/gui/qt/medialibrary/mlvideo.hpp | 4 ++--
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/modules/gui/qt/medialibrary/mlvideo.cpp 
>> b/modules/gui/qt/medialibrary/mlvideo.cpp
>> index cefb9504d6..8adedbb4d8 100644
>> --- a/modules/gui/qt/medialibrary/mlvideo.cpp
>> +++ b/modules/gui/qt/medialibrary/mlvideo.cpp
>> @@ -177,7 +177,7 @@ void MLVideo::onMlEvent( const vlc_ml_event_t* 
>> event )
>>              
>> .p_media->thumbnails[event->media_thumbnail_generated.i_size].psz_mrl;
>>      m_thumbnail = QString::fromUtf8( thumbnailMrl );
>>      vlc_ml_event_unregister_from_callback( m_ml, 
>> m_ml_event_handle.release() );
>> -    emit onThumbnailChanged( m_thumbnail );
>> +    emit thumbnailChanged( m_thumbnail );
>>  }
>> 
>>  QString MLVideo::getTitle() const
>> diff --git a/modules/gui/qt/medialibrary/mlvideo.hpp 
>> b/modules/gui/qt/medialibrary/mlvideo.hpp
>> index 8041881280..37cdbbab71 100644
>> --- a/modules/gui/qt/medialibrary/mlvideo.hpp
>> +++ b/modules/gui/qt/medialibrary/mlvideo.hpp
>> @@ -85,7 +85,7 @@ class MLVideo : public QObject, public MLItem
>> 
>>      Q_PROPERTY(MLItemId id READ getId CONSTANT);
>>      Q_PROPERTY(QString title READ getTitle CONSTANT);
>> -    Q_PROPERTY(QString thumbnail READ getThumbnail NOTIFY 
>> onThumbnailChanged);
>> +    Q_PROPERTY(QString thumbnail READ getThumbnail NOTIFY 
>> thumbnailChanged);
>>      Q_PROPERTY(QString duration READ getDuration CONSTANT);
>>      Q_PROPERTY(QString durationShort READ getDurationShort CONSTANT);
>>      Q_PROPERTY(QString mrl READ getMRL CONSTANT);
>> @@ -118,7 +118,7 @@ public:
>>      MLVideo* clone(QObject* parent = nullptr) const;
>> 
>>  signals:
>> -    void onThumbnailChanged( QString );
>> +    void thumbnailChanged( QString );
>> 
>>  private:
>>      MLVideo(const MLVideo& video, QObject* parent = nullptr);
>> --
>> 2.29.2
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel