[vlc-devel] [PATCH 27/27] qml: fix chapter buttons being invisible in toolbareditor

Fatih Uzunoglu fuzun54 at outlook.com
Fri Dec 4 00:02:02 CET 2020


+ change its normal behavior from being invisible to being disabled when there are not chapters.
+ fix sizing issue
---
 modules/gui/qt/player/qml/ControlButtons.qml | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/modules/gui/qt/player/qml/ControlButtons.qml b/modules/gui/qt/player/qml/ControlButtons.qml
index 65e14ed1b5..57411351db 100644
--- a/modules/gui/qt/player/qml/ControlButtons.qml
+++ b/modules/gui/qt/player/qml/ControlButtons.qml
@@ -365,13 +365,11 @@ Item{
     Component{
         id: chapterPreviousBtnDelegate
         Widgets.IconToolButton {
-            id: chapterPreviousBtnDelegate
+            id: chapterPreviousBtn
             size: VLCStyle.icon_medium
-            width: visible? VLCStyle.icon_medium : 0
             iconText: VLCIcons.dvd_prev
             onClicked: player.chapterPrev()
-            visible: player.hasChapters
-            enabled: visible
+            enabled: !paintOnly && player.hasChapters
             property bool acceptFocus: visible
             text: i18n.qtr("Previous chapter")
         }
@@ -381,13 +379,11 @@ Item{
     Component{
         id: chapterNextBtnDelegate
         Widgets.IconToolButton {
-            id: chapterPreviousBtnDelegate
+            id: chapterNextBtn
             size: VLCStyle.icon_medium
-            width: visible? VLCStyle.icon_medium : 0
             iconText: VLCIcons.dvd_next
             onClicked: player.chapterNext()
-            visible: player.hasChapters
-            enabled: visible
+            enabled: !paintOnly && player.hasChapters
             property bool acceptFocus: visible
             text: i18n.qtr("Next chapter")
         }
-- 
2.27.0



More information about the vlc-devel mailing list