[vlc-devel] [PATCH] csa: do not handle impossible NULL argument

Steve Lhomme robux4 at ycbcr.xyz
Fri Dec 4 10:17:52 CET 2020


On 2020-12-04 9:54, Romain Vimont wrote:
> On Thu, Dec 03, 2020 at 10:14:49AM +0100, Steve Lhomme wrote:
>> p_sys->csa in ts.c can be NULL (see csaSetup()) and the ts code will work
>> fine. So the NULL case is very much used (and I believe the common case).
> 
> csa_UseKey() is only called from ActiveKeyCallback(), which is
> registered only when csa is not NULL.

OK. That explanation should be in the commit log.

> So the patch LGTM.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list