[vlc-devel] [PATCH 1/2] vlc_arrays: Return dict hash as size_t
robux4 at ycbcr.xyz
Fri Dec 4 10:47:30 CET 2020
patchset LGTM and proposal on dict size as well.
On 2020-12-04 10:44, Hugo Beauzée-Luyssen wrote:
> On Fri, Dec 4, 2020, at 10:36 AM, Francois Cartegnie wrote:
>> Le 04/12/2020 à 10:31, Hugo Beauzée-Luyssen a écrit :
>>> As they are used as index, this type is more appropriate
>> hashsize is signed int, so that does not make any difference.
> Agreed, but changing that will lead to a change in vlc_dictionary_keys_count's return type, which would cascade notably to the ts attachment handling which is expected to return a count as int.
> I'm fine changing the dict size to a size_t, as it makes a lot more sense than a signed integer, but I'm afraid this will cascade a bit too far out of this patchset scope
> Hugo Beauzée-Luyssen
> hugo at beauzee.fr
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel