[vlc-devel] [PATCH 09/12] network: io: Remove VLA usages

Steve Lhomme robux4 at ycbcr.xyz
Wed Dec 9 10:14:19 CET 2020


On 2020-12-09 10:11, Steve Lhomme wrote:
> On 2020-12-09 10:06, RĂ©mi Denis-Courmont wrote:
>> Callers don't expect and can't handle ENOMEM error here. If you don't 
>> understand, abstain from commenting instead of making stupid wrong 
>> comments.
> 
> "Callers don't expect errors here" is very different than "Callers don't 
> expect and can't handle ENOMEM error here".
> 
> And the net_Accept() documentation doesn't mention that. And in fact, 
> apart from Lua that just passes on the value, all the callers check for 
> -1 and don't care about the actual type of errors.
> 
> So this fine is perfectly fine.
s/fine/patch/


More information about the vlc-devel mailing list