[vlc-devel] [PATCH 1/2] actions: Fix MAXACTION value

Romain Vimont rom1v at videolabs.io
Thu Dec 10 17:41:29 CET 2020


On Thu, Dec 10, 2020 at 05:15:26PM +0100, Hugo Beauzée-Luyssen wrote:
> The longuest string is 26 characters long, not including terminal null
> byte
> ---
>  src/misc/actions.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/misc/actions.c b/src/misc/actions.c
> index b10b07936e..ddbf04ad65 100644
> --- a/src/misc/actions.c
> +++ b/src/misc/actions.c
> @@ -255,7 +255,7 @@ found:
>  
>  /*** VLC key map ***/
>  
> -#define MAXACTION 26
> +#define MAXACTION 27
>  static const struct name2action
>  {
>      char psz[MAXACTION];

Is there a reason not to use:

    const char *psz;

instead of counting the number of characters (and losing space)?

Regards


More information about the vlc-devel mailing list