[vlc-devel] [PATCH 1/3] vlc_plugin.h: Move the EXTERN_SYMBOL definition higher in the file

Steve Lhomme robux4 at ycbcr.xyz
Fri Dec 11 09:26:01 CET 2020


patchset LGTM

On 2020-12-10 15:43, Hugo Beauzée-Luyssen wrote:
> No functional change
> ---
>   include/vlc_plugin.h | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/include/vlc_plugin.h b/include/vlc_plugin.h
> index 7a68c953e3..88317c88db 100644
> --- a/include/vlc_plugin.h
> +++ b/include/vlc_plugin.h
> @@ -204,6 +204,12 @@ enum vlc_module_properties
>   #define CONCATENATE( y, z ) CRUDE_HACK( y, z )
>   #define CRUDE_HACK( y, z )  y##__##z
>   
> +#if defined(__cplusplus)
> +#define EXTERN_SYMBOL extern "C"
> +#else
> +#define EXTERN_SYMBOL
> +#endif
> +
>   /* If the module is built-in, then we need to define foo_InitModule instead
>    * of InitModule. Same for Activate- and DeactivateModule. */
>   #ifdef __PLUGIN__
> @@ -230,12 +236,6 @@ enum vlc_module_properties
>   # define DLL_SYMBOL
>   #endif
>   
> -#if defined( __cplusplus )
> -#   define EXTERN_SYMBOL           extern "C"
> -#else
> -#   define EXTERN_SYMBOL
> -#endif
> -
>   EXTERN_SYMBOL typedef int (*vlc_set_cb) (void *, void *, int, ...);
>   
>   #define vlc_plugin_set(...) vlc_set (opaque,   NULL, __VA_ARGS__)
> -- 
> 2.29.2
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list