[vlc-devel] [PATCH 09/12] network: io: Remove VLA usages

Pierre Ynard linkfanel at yahoo.fr
Fri Dec 11 16:18:21 CET 2020

> That sounds like maintaining 2 different versions of the same code. 
> That's not a good idea IMO.

That's more or less what we already do in plenty of places. It certainly
sounds like a decent idea to me, and it sounds feasible to do it with
just a few lines within #ifdef's; but again, the merits would be on a
case-by-case basis. It's up to the developer writing the patch to come
up with the best implementation of this in each case, one that looks as
little as possible like maintaining two different versions of the same
code; I'm all for the most elegant solutions.

On the contrary, banning VLAs would sound like letting the project be
driven by the lowest common denominator, and I think that would be a
worse idea.

Come on, we've already eliminated some of the less relevant uses of
VLAs, it can't be that hard to agree on which are actually beneficial to
the code and then work out a few fallbacks for them.

Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."

More information about the vlc-devel mailing list