[vlc-devel] [RFC PATCH] arm_neon/volume: don't specify symbol name

[Zhao Zhili]

> On Dec 9, 2020, at 5:23 PM, Zhao Zhili <quinkblack at foxmail.com> wrote:
> 
> Since the symbol prefix is handled by asm.S already.
> ---
> Since I can't setup a working build environment for iOS, the patch is
> not tested.

volume_neon_plugin is removed explicitly in VLCKit. HAVE_NEON is false.
So looks like no platform is affected by the bug.

> 
> modules/arm_neon/volume.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/arm_neon/volume.c b/modules/arm_neon/volume.c
> index 0ed1d2ed23..910c9b507b 100644
> --- a/modules/arm_neon/volume.c
> +++ b/modules/arm_neon/volume.c
> @@ -55,7 +55,7 @@ static int Probe(vlc_object_t *obj)
>     return VLC_SUCCESS;
> }
> 
> -void amplify_float_arm_neon(float *, const float *, size_t, float) asm("amplify_float_arm_neon");
> +void amplify_float_arm_neon(float *, const float *, size_t, float);
> 
> static void AmplifyFloat(audio_volume_t *volume, block_t *block, float amp)
> {
> -- 
> 2.28.0
>