[vlc-devel] [PATCH 04/30] qml: remove unused highlight properties from table view

Prince Gupta guptaprince8832 at gmail.com
Mon Dec 14 14:27:42 CET 2020


we separately implement highlight rect for each item and this was causing unexpected scrolling when user clicks any item in view
---
 modules/gui/qt/widgets/qml/KeyNavigableListView.qml | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/modules/gui/qt/widgets/qml/KeyNavigableListView.qml b/modules/gui/qt/widgets/qml/KeyNavigableListView.qml
index fa506e7eef..80d92528d2 100644
--- a/modules/gui/qt/widgets/qml/KeyNavigableListView.qml
+++ b/modules/gui/qt/widgets/qml/KeyNavigableListView.qml
@@ -131,14 +131,6 @@ NavigableFocusScope {
         //key navigation is reimplemented for item selection
         keyNavigationEnabled: false
 
-        preferredHighlightBegin : (view.orientation === ListView.Vertical)
-                                    ? highlightMargin + (headerItem ? headerItem.height : 0)
-                                    : highlightMargin
-        preferredHighlightEnd : (view.orientation === ListView.Vertical)
-                                    ? height - highlightMargin
-                                    : width - highlightMargin
-        highlightRangeMode: ListView.ApplyRange
-
         focus: true
 
         clip: true
-- 
2.25.1



More information about the vlc-devel mailing list