[vlc-devel] [PATCH] keystore: always store to the memory keystore

Thomas Guillem thomas at gllm.fr
Tue Dec 15 16:01:37 CET 2020

On Tue, Dec 15, 2020, at 15:50, Rémi Denis-Courmont wrote:
> Le mardi 15 décembre 2020, 14:03:04 EET Thomas Guillem a écrit :
> > The memory keystore was never used if the system keystore was
> > functional. This caused several issue:
> >  - No caching of the system keystore (slower)
> >  - Guest account always tried in the first place on some access modules
> >    (mainly SMB ones).
> Both of those alleged issues seem like intended behaviour, also not related, 
> and with the later not a core concern.

And yet, it's very hard to fix the Guest connection issue inside a module.
Indeed, requesting the system keystore can cause a user interaction (enter a passphrase, pin, fingerprint), that is why it is requested after the second try. So if the memory keystore is not used, you won't be able to get the last saved credential on the first try.

As a result, when browsing smb2, you will always try to connect to the Guest account first, then use the user one.

> And it's not clear from the description how cache maintenance (cleaning and 
> invalidation) would work.

The memory keystore can't be cleared for now. It's easy to implement but it needs a new UI and a libvlc API.
For the system one, you should use the application (like seahorse on Gnome)

When logging with gnome nautilus on network shares, it is not possible to clear the cache if you choose to remember until logout (default choice). I wanted to reproduce the same behavior with VLC.

> -- 
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list