[vlc-devel] [PATCH 2/5] video_output: move the dead (don't push) control handling in video_output

[Steve Lhomme]

On 2020-12-18 8:47, Rémi Denis-Courmont wrote:
> Le perjantaina 18. joulukuuta 2020, 7.48.13 EET Steve Lhomme a écrit :
>> On 2020-12-17 21:37, Rémi Denis-Courmont wrote:
>>> Le torstaina 17. joulukuuta 2020, 17.39.16 EET Steve Lhomme a écrit :
>>>> Only the code that pushes code need to know it's not supposed to push
>>>> anything anymore. So far it was under a lock of the control thread. We
>>>> use
>>>> an atomic boolean instead.
>>>
>>> This is not equivalent and leads to races.
>>
>> Please explain.
> 
> This breaks atomicity in a number of places.

Where ?