[vlc-devel] [PATCH v4 0/9] simplify vout:control

Steve Lhomme robux4 at ycbcr.xyz
Fri Dec 18 08:38:19 UTC 2020

Changes since v3:
- move the is_held check early in control_Pop as we shouldn't try to do anything while other parts of the code are still doing things on the vout
- merge the two wait conditions into one, the secondary one was mostly to block control_Hold which can be done with is_held
- more comments in the code
- explain whay the atomic control_is_dead is fine (the vout thread is dead and any more pushed commands will be free'd afterwards).

Steve Lhomme (9):
  video_output:control: remove unused vout_control_WaitEmpty declaration
  video_output: make a function per push command
  video_output: move the dead (don't push) control handling in
  video_output:control: de-factorize vout_control_Push code
  video_output:control: handle the terminate state internally in the
    control FIFO
  video_output: pop mouse events and terminated state from the control
  video_output: handle the termination of the vout thread outside of
  video_output:control: explain why we keep can_sleep to false
  video_output:control: merge the two wait conditions

 src/video_output/control.c      | 64 +++++++++++----------------------
 src/video_output/control.h      | 29 ++-------------
 src/video_output/video_output.c | 42 +++++++++++++---------
 3 files changed, 49 insertions(+), 86 deletions(-)


More information about the vlc-devel mailing list