[vlc-devel] [PATCH 4/5] video_output: handle the terminate state internally in the control FIFO

Romain Vimont rom1v at videolabs.io
Fri Dec 18 08:57:11 UTC 2020

On Thu, Dec 17, 2020 at 05:44:19PM +0100, Thomas Guillem wrote:
> Are you sure about this one?
> Before your patch, TERMINATE was a pseudo drain, the vout thread was stopped once it had processed all controls. What about remaining pictures?
> On Thu, Dec 17, 2020, at 16:39, Steve Lhomme wrote:
> > It doesn't push a dummy command anymore but sets an internal flag.
> > 
> > If the control FIFO is terminated we don't wait for new commands before
> > returning. There might be some pending mouse commands before the TERMINATED
> > command (that is now removed).

Btw, currently, VOUT_CONTROL_TERMINATE terminates the vout thread, so no
more vout_control_Pop() will never be called again.

What if a separate thread was waiting on vout_control_Hold()? It will
hang forever.

More information about the vlc-devel mailing list