[vlc-devel] [PATCH 4/4] RFC: keystore: use the system keystore from the first try

Thomas Guillem thomas at gllm.fr
Fri Dec 18 10:31:41 UTC 2020

Currently, all access modules are first requesting credentials without
triggering a dialog. This caused the system keystore to never be fetched
on the first try. Therefore some access modules could fallback to a
guest/anonymous account when a valid credential was saved on the system

Now the system keystore will be fetched from the first try. Access
modules will still fallback to a guest/anonymous account if the system
keystore doesn't have any credentials (before prompting credentials via
a dialog).

RFC: This last point could be discussed.

We could also trigger a dialog from the first try to let the user decide
if he should use its account or an anonymous one. Currently, most Linux
browsers (Gnome/KDE) are using that solution.

In addition and regardless what we decide on the last point, we should
provide a way for the user to retrigger a credential dialog in case the
user want to switch from guest to its account or to switch between 2
 src/misc/keystore.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/misc/keystore.c b/src/misc/keystore.c
index 8fcc6523671..09058dfb7e0 100644
--- a/src/misc/keystore.c
+++ b/src/misc/keystore.c
@@ -489,9 +489,6 @@ vlc_credential_get(vlc_credential *p_credential, vlc_object_t *p_parent,
         case GET_FROM_KEYSTORE:
-            if (!psz_dialog_title || !psz_dialog_fmt)
-                return false;
             if (p_credential->p_keystore == NULL)
                 p_credential->p_keystore = vlc_keystore_create(p_parent);
             if (p_credential->p_keystore != NULL)

More information about the vlc-devel mailing list