[vlc-devel] [PATCH 3/3] decoder: delay controls when output is not started

[Thomas Guillem]

On Fri, Dec 18, 2020, at 12:30, Rémi Denis-Courmont wrote:
> Le torstaina 17. joulukuuta 2020, 11.52.05 EET Thomas Guillem a écrit :
> > This fixes rate and delay ignored if the command is sent before the
> > output is started.
> > 
> > The "continue" is removed from the loop in order to avoid
> > DecoderThread_Change*() busy loop.
> 
> You can't remove the continue after unlocking; you have to recheck from the 
> beginning, or this will lead to invalid states.

Yes, and this patch is wrong, I should fix the reset_out_state handling instead, cf.  12918e13b2b2da93f2fd34f0866624c4ac9b1028.

> 
> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel