[vlc-devel] [PATCH 0/4] qt: Remove QObject from MLVideo
Romain Vimont
rom1v at videolabs.io
Fri Dec 18 13:53:32 UTC 2020
Since asynchronous loading, list items are created from a QThreadPool thread.
As a consequence, as a QObject, each one live in this separate thread.
The behavior of dynamic properties or signals/slots would be confusing, so do
not inherit QObject.
This patchset only changes MLVideo, other item types must also be updated
(later).
Romain Vimont (4):
qt: medialib: remove properties from model items
qt: medialib: remove items clone()
qt: medialib: convert description into Q_GADGET
qt: medialib: remove QObject from MLVideo
modules/gui/qt/maininterface/mainui.cpp | 1 -
modules/gui/qt/medialibrary/mlalbum.cpp | 20 -------
modules/gui/qt/medialibrary/mlalbum.hpp | 15 -----
modules/gui/qt/medialibrary/mlalbumtrack.cpp | 21 -------
modules/gui/qt/medialibrary/mlalbumtrack.hpp | 19 ------
modules/gui/qt/medialibrary/mlartist.cpp | 18 ------
modules/gui/qt/medialibrary/mlartist.hpp | 11 ----
modules/gui/qt/medialibrary/mlgenre.cpp | 20 +------
modules/gui/qt/medialibrary/mlgenre.hpp | 13 +----
.../gui/qt/medialibrary/mlrecentsmodel.cpp | 5 --
.../gui/qt/medialibrary/mlrecentsmodel.hpp | 2 -
modules/gui/qt/medialibrary/mlurlmodel.cpp | 4 --
modules/gui/qt/medialibrary/mlurlmodel.hpp | 2 -
modules/gui/qt/medialibrary/mlvideo.cpp | 58 ++++++-------------
modules/gui/qt/medialibrary/mlvideo.hpp | 54 ++++++-----------
15 files changed, 37 insertions(+), 226 deletions(-)
--
2.29.2
More information about the vlc-devel
mailing list