[vlc-devel] [PATCH v3 00/11] credential rework

Thomas Guillem thomas at gllm.fr
Mon Dec 21 17:54:25 UTC 2020

Changes since the last set:

 - remove "keystore: use the system keystore in priority"
   it is useless since the user will be able to invalidate the cache keystore
   (cf. next patches).

 - Add a flag to force the user interaction (via dialogs). It will be used
   via LibVLC and VLC interfaces. This can be used to change the logged

 - Send the logged user to LibVLC and VLC interfaces. For the Qt UI, we
   could add a widget near the URL widget displaying "logged as <User>", if
   clicked, it will force a reload with a forced user interaction.

NB: if accepted, I will implement interacted_forced (if needed) and
user propagation on all other accesses.

Thomas Guillem (11):
  keystore: refactor next order handling
  keystore: prevent UI interaction if no_interact
  keystore: always store to the memory keystore
  keystore: use the system keystore from the first try
  input: change b_preparse_interact type
  crendential: add an option to force user interaction
  smb2: don't try guest account when requested
  input: add input_item_node_SetLoggedUser()
  smb2: send the logged username
  libvlc: propagate the logged user
  libvlc: add an option to force user interaction

 include/vlc/libvlc_events.h |  3 ++
 include/vlc/libvlc_media.h  |  5 +++
 include/vlc_input_item.h    | 21 +++++++++-
 include/vlc_keystore.h      |  5 +++
 lib/media.c                 |  3 ++
 modules/access/smb2.c       | 12 ++++++
 src/input/input.c           |  8 +++-
 src/input/item.c            |  9 +++++
 src/input/var.c             |  3 ++
 src/libvlccore.sym          |  1 +
 src/misc/keystore.c         | 78 ++++++++++++++++++++++++-------------
 src/preparser/preparser.c   |  6 ++-
 12 files changed, 123 insertions(+), 31 deletions(-)


More information about the vlc-devel mailing list