[vlc-devel] [PATCH v3 04/11] keystore: use the system keystore from the first try

Thomas Guillem thomas at gllm.fr
Mon Dec 21 17:54:29 UTC 2020

Currently, all access modules are first requesting credentials without
triggering a dialog. This caused the system keystore to never be fetched
on the first try. Therefore some access modules could fallback to a
guest/anonymous account when a valid credential was saved on the system

Now the system keystore will be fetched from the first try. Access
modules will still fallback to a guest/anonymous account if the system
keystore doesn't have any credentials (before prompting credentials via
a dialog).
 src/misc/keystore.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/misc/keystore.c b/src/misc/keystore.c
index 90be77e24b0..93470ae3440 100644
--- a/src/misc/keystore.c
+++ b/src/misc/keystore.c
@@ -461,9 +461,6 @@ vlc_credential_get(vlc_credential *p_credential, vlc_object_t *p_parent,
         case GET_FROM_KEYSTORE:
-            if (!psz_dialog_title || !psz_dialog_fmt)
-                return false;
             if (p_credential->p_keystore == NULL)
                 p_credential->p_keystore = vlc_keystore_create(p_parent);
             if (p_credential->p_keystore != NULL)

More information about the vlc-devel mailing list