[vlc-devel] [PATCH v3 02/11] keystore: prevent UI interaction if no_interact

Thomas Guillem thomas at gllm.fr
Tue Dec 22 10:01:42 UTC 2020

On Tue, Dec 22, 2020, at 10:45, Rémi Denis-Courmont wrote:
> Le tiistaina 22. joulukuuta 2020, 11.32.52 EET Thomas Guillem a écrit :
> > That is why the memory keystore come into action.
> > The user unlock the system keystore from a UI action, the memory keystore is
> > saved, and next preparsing requests can be done in background without any
> > UI interaction, using the memory keystore.
> No. The memory keystore is helpless here because in practice VLC will pretty 
> much always start preparsing before opening the media, and thus always fail 
> under that design.
> AFAICT, it is intended that we don't ask the user for credentials while 
> preparsing. That's *not* to say that we don't ask the user to unlock their 
> password wallet. Same as browsers do, really.

I have no strong arguments on that matter and it's the right time to change the current behavior.
So, to resume, we have 2 choices:

 - Always enable and use the system keystore (even when parsing in background). The system keystore will have a priority higher than the cache keystore. So, if the system keystore is unlocked, the cache keystore will never be used.
/!\ WARNING: It may trigger a dialog from the OS asking for a pin/passphrase to unlock the wallet. It should not have a big impact since most OSses generally unlock the keystore when the user logs in.

 - Keep the behavior I proposed on the ML The system keystore is not used for background parsing. Therefore, background parsing will only work if the user specifically request it from (from a direct or indirect action).

> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list