[vlc-devel] [PATCH] skins: fix signed overflow in bitmap allocation

[Alexandre Janniaux]

Hi,

This should be fixed with the patch I've sent a few
minutes ago. If there are other issues, please report
them and I'll fix them too. ;)

Regards,
--
Alexandre Janniaux
Videolabs

On Wed, Dec 23, 2020 at 12:48:24AM +0100, erwan.tulou at gmail.com wrote:
> Thank for answering.
>
> Right now, the maintenance effort required to just keep it running is not
> met. So the next step may be to re-apply the patch that disabled skins2
> compilation a while ago. At least, that will prevent nightlies from shipping
> a skins2 module that keeps crashing desperately.
>
> I'm not sure I still have commit rights. So, if somebody decides to re-apply
> this patch, no problem with me.
>
> Regards
> Erwan
>
> On 22/12/2020 21:32, Rémi Denis-Courmont wrote:
>
> > Le tiistaina 22. joulukuuta 2020, 20.41.42 EET erwan.tulou at gmail.com a écrit :
> > >     As of today, the skins2 module is broken (crashing). The last patch
> > > to try and fix it did not receive much attention. And it seems to me the
> > > Qt module is evolving without much care about how the skins2 module may
> > > be impacted.
> > As far as I see, the Qt module is evolving without much care for anything
> > except the Qt GUI on Windows. And I presume that even Windows is afflicted by
> > the UX regressions reported on Trac by François, and performance issues.
> >
> > >     So, maybe time has come to ask the questions  :  is it worth
> > > maintaining it or not ?
> > That depends on how you measure worth.
> >
> > > what are the plans ?
> > There are no plans. This is not waterfall. If you continue maintaining it, or
> > if somebody else takes over, then it will be there. Otherwise, it will bit-rot
> > and, at some point, get removed.
> >
> > > any new maintainers interested ?
> > I don't know, but presumably not.
> >
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel