[vlc-devel] [PATCH 3/7] ios vout: signal while holding the lock

RĂ©mi Denis-Courmont remi at remlab.net
Mon Feb 3 22:13:14 CET 2020


This is the 21st century. The C run-time threading subsystem knows better
than you how to optimise condition variables.
---
 modules/video_output/ios.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/video_output/ios.m b/modules/video_output/ios.m
index 5ef0a27328..6424da7604 100644
--- a/modules/video_output/ios.m
+++ b/modules/video_output/ios.m
@@ -621,8 +621,8 @@ static void GLESSwap(vlc_gl_t *gl)
     vlc_mutex_lock(&_mutex);
     assert(_gl_attached);
     _gl_attached = NO;
-    vlc_mutex_unlock(&_mutex);
     vlc_cond_signal(&_gl_attached_wait);
+    vlc_mutex_unlock(&_mutex);
 }
 
 - (void)presentRenderbuffer
-- 
2.25.0



More information about the vlc-devel mailing list