[vlc-devel] [PATCH 09/18] libvlc: rename the OpenGL callbacks cleanup callback type

Steve Lhomme robux4 at ycbcr.xyz
Tue Feb 4 16:26:04 CET 2020


Avoid confusion with the cleanup callback from libvlc_video_set_format_callbacks
even though the prototype is the same.
---
 include/vlc/libvlc_media_player.h | 4 ++--
 lib/media_player.c                | 2 +-
 modules/video_output/vgl.c        | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/vlc/libvlc_media_player.h b/include/vlc/libvlc_media_player.h
index 8b1ce6466b0..a327d0cd503 100644
--- a/include/vlc/libvlc_media_player.h
+++ b/include/vlc/libvlc_media_player.h
@@ -519,7 +519,7 @@ typedef bool (*libvlc_video_setup_cb)(void* opaque);
  * \param opaque private pointer passed to the @a libvlc_video_set_output_callbacks() [IN]
  * \version LibVLC 4.0.0 or later
  */
-typedef void (*libvlc_video_cleanup_cb)(void* opaque);
+typedef void (*libvlc_video_output_cleanup_cb)(void* opaque);
 
 typedef struct
 {
@@ -661,7 +661,7 @@ LIBVLC_API
 bool libvlc_video_set_output_callbacks( libvlc_media_player_t *mp,
                                         libvlc_video_engine_t engine,
                                         libvlc_video_setup_cb setup_cb,
-                                        libvlc_video_cleanup_cb cleanup_cb,
+                                        libvlc_video_output_cleanup_cb cleanup_cb,
                                         libvlc_video_update_output_cb update_output_cb,
                                         libvlc_video_swap_cb swap_cb,
                                         libvlc_video_makeCurrent_cb makeCurrent_cb,
diff --git a/lib/media_player.c b/lib/media_player.c
index d93813f7598..8fb79a8e2f5 100644
--- a/lib/media_player.c
+++ b/lib/media_player.c
@@ -1034,7 +1034,7 @@ void libvlc_video_set_format( libvlc_media_player_t *mp, const char *chroma,
 bool libvlc_video_set_output_callbacks(libvlc_media_player_t *mp,
                                        libvlc_video_engine_t engine,
                                        libvlc_video_setup_cb setup_cb,
-                                       libvlc_video_cleanup_cb cleanup_cb,
+                                       libvlc_video_output_cleanup_cb cleanup_cb,
                                        libvlc_video_update_output_cb update_output_cb,
                                        libvlc_video_swap_cb swap_cb,
                                        libvlc_video_makeCurrent_cb makeCurrent_cb,
diff --git a/modules/video_output/vgl.c b/modules/video_output/vgl.c
index e8e8f353d17..ee00b1f859f 100644
--- a/modules/video_output/vgl.c
+++ b/modules/video_output/vgl.c
@@ -37,7 +37,7 @@
 
 struct vout_display_sys_t
 {
-    libvlc_video_cleanup_cb cleanupCb;
+    libvlc_video_output_cleanup_cb cleanupCb;
     libvlc_video_setup_cb setupCb;
     libvlc_video_update_output_cb resizeCb;
     libvlc_video_swap_cb swapCb;
-- 
2.17.1



More information about the vlc-devel mailing list