[vlc-devel] [PATCH 00/14] qml: fix network browsing issues

Pierre Lamot pierre at videolabs.io
Thu Feb 6 13:56:37 CET 2020


This branch fixes issues related to the network navigation.

  * crashes when closing VLC during a preparse
  * use artwork provided by the media_tree / media_source when available
  * initial focus of the view being either misplaced or unusable when navigating

original branch is available at: https://code.videolan.org/chub/vlc/tree/qml/network-fixes

Pierre Lamot (14):
  media_tree: allow preparse tasks to be canceled
  qt: cancel preparse requests before destroying/changing model of
    NetworkMediaModel
  qt: refcount children passed to onItemAdded in NetworkMediaModel
  qt: retreive the artwork when available in network models
  qml: display the associated artwork when available in network views
  qml: set differentiated highlight zone in KeyNavigableListView when
    the layout is Horizontal
  qml: avoid binding loop in KeyNavigableListView
  qml: fix initial focus not beeing set to the first item in
    NetworkHomeDisplay
  qml: set the focus on the first section in list in NetworkHomeDisplay
  qml: set the initial focus when the delegate model of
    NetworkBrowseDisplay is populated
  qml: recursively traverse disabled NavigableFocusScope
  qml: don't focus the 'add to medialibary' button when invisible
  qml: remove uri below the file name while browsing network
  qml: remove debug messages

 include/vlc_media_source.h                    | 13 +++-
 .../gui/macosx/media-source/VLCMediaSource.m  |  2 +-
 modules/gui/qt/network/networkdevicemodel.cpp | 11 ++++
 modules/gui/qt/network/networkdevicemodel.hpp |  1 +
 modules/gui/qt/network/networkmediamodel.cpp  | 60 +++++++++++++++----
 modules/gui/qt/network/networkmediamodel.hpp  |  8 ++-
 .../qt/network/qml/NetworkBrowseDisplay.qml   | 15 ++---
 .../gui/qt/network/qml/NetworkGridItem.qml    |  4 ++
 .../gui/qt/network/qml/NetworkHomeDisplay.qml | 40 +++++++++++--
 .../gui/qt/network/qml/NetworkListItem.qml    |  4 ++
 .../qml/NetworksSectionSelectableDM.qml       |  1 -
 .../qt/widgets/qml/KeyNavigableListView.qml   | 11 ++--
 modules/gui/qt/widgets/qml/LabelSeparator.qml |  1 +
 .../qt/widgets/qml/NavigableFocusScope.qml    | 48 ++++++++-------
 src/libvlccore.sym                            |  1 +
 src/media_source/media_tree.c                 | 17 +++++-
 16 files changed, 181 insertions(+), 56 deletions(-)

--
2.17.1


More information about the vlc-devel mailing list