[vlc-devel] [PATCH] smb2: limit the read size

Thomas Guillem thomas at gllm.fr
Fri Feb 7 11:11:11 CET 2020

On Thu, Feb 6, 2020, at 17:57, Rémi Denis-Courmont wrote:
> Le torstaina 6. helmikuuta 2020, 17.29.54 EET Thomas Guillem a écrit :
> > This fixes slow probing/seeking when using prefetch since it requests big
> > data size (16MB) for each read().
> The impact of read size on effective stream bandwidth is roughly hyperbolic. 
> Existing Trac report show that 32 KiB is far too little in real life:
> https://trac.videolan.org/vlc/ticket/19988#comment:15

I missed that comment, thanks for you input.
So the faster you are, the less responsive (to seek) you are.

I think I will go between 128k and 1024k. I will do some test at home with my poor wifi setup.

What about your comment "Marking CIFS as fast-seekable".

CIFS is 99% local network (except those using it via ssh/port redirect).
So it should be fast, but lot of people have a bad wifi setup (like me), it's not uncommon to only have 800kb/s (bad router + lot of wifi neighbors in a city).

Is 800kb/s fast enough to enable fast-seekable ?

Crazy idea: live switch between the 2 cache modules depending on the I/O speed.

> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list