[vlc-devel] [PATCH v2 5/5] libvlc: media: set WITH_ASSOCIATED_MEDIA option to preparser

[Alexandre Janniaux]

Hi,

On Mon, Feb 10, 2020 at 11:22:33AM +0100, Thomas Guillem wrote:
>
>
> On Sun, Feb 9, 2020, at 12:11, Alexandre Janniaux wrote:
> > Hi,
> >
> > On Sat, Feb 08, 2020 at 04:35:49PM +0200, Rémi Denis-Courmont wrote:
> > > Le perjantaina 7. helmikuuta 2020, 23.04.49 EET Alexandre Janniaux a écrit :
> > > Also, if it's always set, then I'm not exactly clear why it needs a flag.
> > >
> >
> > The flag is always set for libvlc client, as requested in the
> > previous review, but not for libvlccore users. I'm not sure
> > I can generalize to libvlccore without breaking other users
> > (preparsing, medialibrary, thumbnailing, though I didn't
> > check those).
> >
> > As I mainly want to fix libvlc for this issue, I'd prefer
> > not to include libvlccore change into this patchset,
> > especially since I'm not a user of this API in libvlccore.
> > If it is deemed unecessary by other clients, it could be
> > removed without changing libvlc new behaviour and libvlc
> > API/ABI and the resulting patches will be clearer to
> > interpret.
>
> We could also add a libvlc flag for that, cf. libvlc_media_parse_flag_t

That is actually what was done in the v1 [1] of this patchset.

There was a consensus about not exposing this option to
libVLC at this point. I'm open to merging the first patchset
but it was considered that the libvlc client should never
have to know whether it needs the flag or not.

[1] https://mailman.videolan.org/pipermail/vlc-devel/2019-December/129841.html

Regards,
--
Alexandre Janniaux
Videolabs