[vlc-devel] [PATCH v2 1/5] input_item: add WITH_ASSOCIATED_MEDIA meta request

[Alexandre Janniaux]

Hi,

They could be merged together yes, but I feel that it gave
a better description of the intent with separated patches,
and thus probably an easier review.

If you prefer, I can send a v3 with patches merged, whenever
we reach a new consensus.

Regards,
--
Alexandre Janniaux
Videolabs

On Mon, Feb 10, 2020 at 11:23:42AM +0100, Thomas Guillem wrote:
> Nit: why not merging patches 1, 3 and 4 ? For me, it is part of the the same functionality;
>
> On Fri, Feb 7, 2020, at 22:04, Alexandre Janniaux wrote:
> > This META_REQUEST_ parameter aims at enabling the parsing of
> > input_slaves and similar mechanisms whenever the main media is asked to
> > be parsed. It will be disabled in the default state, providing IO
> > savings for use case which doesn't need it.
> > ---
> >  include/vlc_input_item.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/include/vlc_input_item.h b/include/vlc_input_item.h
> > index 1c99f6c012..da5c11b1c1 100644
> > --- a/include/vlc_input_item.h
> > +++ b/include/vlc_input_item.h
> > @@ -466,6 +466,7 @@ typedef enum input_item_meta_request_option_t
> >      META_REQUEST_OPTION_FETCH_NETWORK = 0x08,
> >      META_REQUEST_OPTION_FETCH_ANY     = 0x0C,
> >      META_REQUEST_OPTION_DO_INTERACT   = 0x10,
> > +    META_REQUEST_OPTION_WITH_ASSOCIATED_MEDIA = 0x20,
> >  } input_item_meta_request_option_t;
> >
> >  /* status of the on_preparse_ended() callback */
> > --
> > 2.25.0
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel