[vlc-devel] [PATCH 0/5] Backport of avaudiocapture module to 3.0 branch

[Thomas Guillem]

Hello,

OK with this set. No objections to backport this new module since the legacy module is broken.

On Mon, Feb 10, 2020, at 19:41, david.fuhrmann at gmail.com wrote:
> From: David Fuhrmann <dfuhrmann at videolan.org>
> 
> Hi there,
> On vlc-3.0, we still have the very deprecated qtsound module for
> audio capture. The underlying Framework of this module is deprecated
> since a long time, and starting with macOS Catalina (the newest version)
> it just does not work anymore (i.e. it does not find any audio devices
> anymore).
> 
> I would like to backport now the successor, avaudiocapture, to the 3.0
> branch, to restore this functionality. avaudiocapture uses the new
> AVFoundation framework, which is available starting 10.7 (= the first
> os version we still support on 3.0).
> 
> Code has been tested both on 10.14 and 10.15, as well as on the old
> 10.7 laptop I still have.
> 
> BR. David
> 
> David Fuhrmann (5):
>   avaudiocapture: Add audio capture module based on AVFoundation
>     framework
>   qtsound: Remove module
>   macOS/configure.sh: Remove qtkit build option
>   macosx: Use avaudiocapture module instead of qtsound
>   avaudiocapture: Inform user when microphone access is not granted
> 
>  configure.ac                                  |  19 +-
>  extras/package/macosx/configure.sh            |   1 -
>  .../macosx/vlc.xcodeproj/project.pbxproj      |   2 -
>  modules/MODULES_LIST                          |   2 +-
>  modules/access/Makefile.am                    |  10 +-
>  modules/access/avaudiocapture.m               | 348 +++++++++++
>  modules/access/qtsound.m                      | 586 ------------------
>  modules/gui/macosx/VLCOpenWindowController.m  |  14 +-
>  po/POTFILES.in                                |   4 +-
>  9 files changed, 366 insertions(+), 620 deletions(-)
>  create mode 100644 modules/access/avaudiocapture.m
>  delete mode 100644 modules/access/qtsound.m
> 
> -- 
> 2.21.1 (Apple Git-122.3)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel