[vlc-devel] [PATCH 1/2] qt: don't create the "window" variable in libvlc

[Steve Lhomme]

On 2020-02-13 10:04, Thomas Guillem wrote:
> 
> On Thu, Feb 13, 2020, at 09:21, Steve Lhomme wrote:
>> The variable already already exists.
>>
>> We could assert when trying to create a variable that doesn't exist, just like
>> we assert when trying to read a variable that doesn't exist.
> 
> typo ?
> We could assert when trying to create a variable that *already exist*, just like

Yes.

>> ---
>>   modules/gui/qt/qt.cpp | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/modules/gui/qt/qt.cpp b/modules/gui/qt/qt.cpp
>> index 88f3427d166..c7b70b22d30 100644
>> --- a/modules/gui/qt/qt.cpp
>> +++ b/modules/gui/qt/qt.cpp
>> @@ -681,7 +681,6 @@ static void *Thread( void *obj )
>>           libvlc_int_t *libvlc = vlc_object_instance( p_intf );
>>   
>>           var_Create( libvlc, "qt4-iface", VLC_VAR_ADDRESS );
>> -        var_Create( libvlc, "window", VLC_VAR_STRING );
>>   
>>           if( known_type )
>>           {
>> @@ -731,7 +730,6 @@ static void *Thread( void *obj )
>>       if (p_mi != NULL)
>>       {
>>           libvlc_int_t *libvlc = vlc_object_instance( p_intf );
>> -        var_Destroy( libvlc, "window" );
>>           var_Destroy( libvlc, "qt4-iface" );
>>       }
>>       return ThreadCleanup( p_intf, false );
>> -- 
>> 2.17.1
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>