[vlc-devel] [PATCH] doc: add a Makefile to build sample apps

[Steve Lhomme]

On 2020-02-13 12:43, Marvin Scholz wrote:
> 
> 
> On 13 Feb 2020, at 9:46, Steve Lhomme wrote:
> 
>> On 2020-02-13 9:20, Steve Lhomme wrote:
>>> ---
>>>   configure.ac           |  1 +
>>>   doc/libvlc/Makefile.am | 35 +++++++++++++++++++++++++++++++++++
>>>   2 files changed, 36 insertions(+)
>>>   create mode 100644 doc/libvlc/Makefile.am
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index d0bd45318ef..26af0250a6e 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -4529,6 +4529,7 @@ AC_SUBST([FILE_LIBVLC_DLL])
>>>   AC_CONFIG_FILES([
>>>     Makefile
>>>     doc/Makefile
>>> +  doc/libvlc/Makefile
>>>     modules/Makefile
>>>     m4/Makefile
>>>     po/Makefile.in
>>> diff --git a/doc/libvlc/Makefile.am b/doc/libvlc/Makefile.am
>>> new file mode 100644
>>> index 00000000000..b30f97ef857
>>> --- /dev/null
>>> +++ b/doc/libvlc/Makefile.am
>>> @@ -0,0 +1,35 @@
>>> +SUFFIXES = .c .cpp .ui .h .hpp .moc.cpp
>>> +
>>> +moc_verbose = $(moc_verbose_$(V))
>>> +moc_verbose_ = $(moc_verbose__$(AM_DEFAULT_VERBOSITY))
>>> +moc_verbose_0 = @echo "  MOC   " $@;
>>> +moc_verbose__0 = $(moc_verbose_0)
>>> +
>>> +nodist_qtgl_libvlc_SOURCES = qtvlcwidget.moc.cpp
>>> +
>>> +qtgl_libvlc_CXXFLAGS = $(AM_CXXFLAGS) $(QT_CFLAGS) $(CXXFLAGS_qt)
>>> +qtgl_libvlc_LDFLAGS = $(AM_LDFLAGS) -Wl,-pdb=
>>
>> Without the pdb part.
>>
> 
> If you not set any flags you can remove it completely,
> as doing qtgl_libvlc_LDFLAGS = $(AM_LDFLAGS) is useless.
> 
>>> +qtgl_libvlc_LDADD = $(QT_LIBS) $(LIBS_qt) $(LIBM) -L../../lib -lvlc
> 
> I believe this is not enough to make it properly depend on libvlc?
> So if the library changes it would not relink this, no?

I think if the libvlc.a or libvlc.so changes when build libvlc the 
program will be linked. At least I've seen this behaviour here.

Right now these samples are not built by default. If you have to run the 
Makefile manually.

>>> +qtgl_libvlc_SOURCES = QtGL/main.cpp QtGL/qtvlcwidget.cpp 
>>> QtGL/qtvlcwidget.h
>>> +
>>> +MOC_CPPFLAGS = $(DEFS) -I$(top_srcdir)/include 
>>> -I$(top_builddir)/include -I$(top_builddir) \
>>> +    $(qtgl_libvlc_CPPFLAGS)
>>> +
>>> +d3d9_player_SOURCES = d3d9_player.c
>>> +d3d9_player_LDADD = -L../../lib -lvlc -ld3d9
>>> +d3d9_player_LDFLAGS = -mwindows -Wc,-static
> 
> Missing $(AM_LDFLAGS)?

Yes.

>>> +
>>> +d3d11_player_SOURCES = d3d11_player.cpp
>>> +d3d11_player_LDADD = -L../../lib -lvlc -ld3d11 -ld3dcompiler_47 -luuid
>>> +d3d11_player_LDFLAGS = -mwindows -Wc,-static
> 
> Same as above.
> 
>>> +
>>> +qtvlcwidget.moc.cpp: QtGL/qtvlcwidget.h
>>> +    $(moc_verbose)$(MOC) $(MOC_CPPFLAGS) -o $@ $<
>>> +
>>> +bin_PROGRAMS =
>>> +if HAVE_WIN32
>>> +bin_PROGRAMS += d3d11_player d3d9_player
>>> +endif
>>> +if ENABLE_QT
>>> +bin_PROGRAMS += qtgl_libvlc
>>> +endif
>>> -- 
>>> 2.17.1
>>>
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel